fix: Prevent truncating invoice lineItem taxRates #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @armordog, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @armordog! Thank you for signing the Singer Contribution License Agreement. |
Author
|
Just a reminder that this is still broken and still reporting incorrect tax rates. |
tax_rate can't be stored as an integer because many states allow fractional tax rates This change makes it match `credit_notes.json` (which stores correctly as a float)
Author
|
Aw man I missed this issue's birthday 🎂 |
|
Looking into this. |
|
This issue is fixed in PR #102. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tax_rate can't be stored as an integer because many states allow fractional tax rates
This change makes it match
credit_notes.json'stax_rate(which stores correctly as a float)Description of change
Changed invoice schema to prevent tax_rate from being stored as an integer
Potential Risks
I have no idea what this will do with existing tables