Skip to content

Add sort_by[asc] param to API request to prevent records overwrite… #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reeslo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add sort_by[asc] param to API request to prevent records overwrite… #35

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55ccbc3
Add sort_by[asc] param to API request, this prevent records overwrite…
loris-av Nov 17, 2020
b1895a6
sort_by param only for supported column/api endpoints
loris-av Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tap_chargebee/streams/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ def sync_data(self):
params = {"updated_at[after]": bookmark_date_posix}
bookmark_key = 'updated_at'

# Add sort_by[asc] by REPLICATION_KEY to prevent data overwrite by oldest deleted records
params['sort_by[asc]'] = self.REPLICATION_KEY

LOGGER.info("Querying {} starting at {}".format(table, bookmark_date))

while not done:
Expand Down