Skip to content

Conversation

ericlebail
Copy link

@ericlebail ericlebail commented Apr 2, 2021

Description of change

Update dependencies version especialy jsonschema.

Manual QA steps

Risks

Rollback steps

  • revert this branch

Copy link

@tino tino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this. I can't install anything atm on meltano 1.87.1 because of dependency conflicts due to the strictness here.

@edgarrmondragon
Copy link

Bump to this. singer-python should not be pinning deps, being a library means it's expected to be installed alongside arbitrary packages with overlapping requirements. If anyone's interested in the subject, https://iscinumpy.dev/post/app-vs-library/ and the related series of posts are a great read.

@keithhackbarth
Copy link

keithhackbarth commented Jun 9, 2023

@vi6hal or @sgandhi1311 - Any chance of getting this merged if you look in the PRs there's 4 or 5 versions of the same thing - seems like its a major blocker to using this repo! Also, recognizing this is open source - happy to do a PR review session if you want to give me temp maintainer access or anything like that that would help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants