Improve warning ux #502
Open
Improve warning ux #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinelaw
force-pushed
the
claude/file-autoopen-warning-ux-LcwPy
branch
2 times, most recently
from
211bb41 to
ef2f5d5
Compare
- Drop animation feature (unnecessary complexity) - Define 3 new hooks: LspServerError, LspStatusClicked, ActionPopupResult - Define 2 new API functions: showActionPopup, disableForLanguage - Each language gets its own plugin (python-lsp.ts, rust-lsp.ts, etc.) - Users can add custom plugins for unsupported languages
sinelaw
pushed a commit
that referenced
this pull request
Dec 29, 2025
This implements the plugin API and bundled plugins for the LSP install helper feature as designed in PR #502. New hooks added: - LspServerError: Fired when LSP fails to start - LspStatusClicked: Fired when user clicks LSP status indicator - ActionPopupResult: Fired when user selects action from popup New API functions: - editor.showActionPopup(options): Show action popup with buttons - editor.disableLspForLanguage(language): Disable LSP for a language Bundled plugins created: - python-lsp.ts: Python LSP helper with pip/pipx install commands - rust-lsp.ts: Rust LSP helper with rustup/brew/cargo commands - typescript-lsp.ts: TypeScript LSP helper with npm/yarn/pnpm commands Note: The popup UI rendering is stubbed (fires 'dismissed' immediately) and LSP disable doesn't persist to config yet. These require additional UI and config integration work.
sinelaw
pushed a commit
that referenced
this pull request
Dec 29, 2025
This implements the plugin API and bundled plugins for the LSP install helper feature as designed in PR #502. New hooks added: - LspServerError: Fired when LSP fails to start - LspStatusClicked: Fired when user clicks LSP status indicator - ActionPopupResult: Fired when user selects action from popup New API functions: - editor.showActionPopup(options): Show action popup with buttons - editor.disableLspForLanguage(language): Disable LSP for a language Bundled plugins created: - python-lsp.ts: Python LSP helper with pip/pipx install commands - rust-lsp.ts: Rust LSP helper with rustup/brew/cargo commands - typescript-lsp.ts: TypeScript LSP helper with npm/yarn/pnpm commands Note: The popup UI rendering is stubbed (fires 'dismissed' immediately) and LSP disable doesn't persist to config yet. These require additional UI and config integration work.
sinelaw
pushed a commit
that referenced
this pull request
Dec 29, 2025
This implements the plugin API and bundled plugins for the LSP install helper feature as designed in PR #502. New hooks added: - LspServerError: Fired when LSP fails to start - LspStatusClicked: Fired when user clicks LSP status indicator - ActionPopupResult: Fired when user selects action from popup New API functions: - editor.showActionPopup(options): Show action popup with buttons - editor.disableLspForLanguage(language): Disable LSP for a language Bundled plugins created: - python-lsp.ts: Python LSP helper with pip/pipx install commands - rust-lsp.ts: Rust LSP helper with rustup/brew/cargo commands - typescript-lsp.ts: TypeScript LSP helper with npm/yarn/pnpm commands Note: The popup UI rendering is stubbed (fires 'dismissed' immediately) and LSP disable doesn't persist to config yet. These require additional UI and config integration work.
sinelaw
pushed a commit
that referenced
this pull request
Dec 29, 2025
This implements the plugin API and bundled plugins for the LSP install helper feature as designed in PR #502. New hooks added: - LspServerError: Fired when LSP fails to start - LspStatusClicked: Fired when user clicks LSP status indicator - ActionPopupResult: Fired when user selects action from popup New API functions: - editor.showActionPopup(options): Show action popup with buttons - editor.disableLspForLanguage(language): Disable LSP for a language Bundled plugins created: - python-lsp.ts: Python LSP helper with pip/pipx install commands - rust-lsp.ts: Rust LSP helper with rustup/brew/cargo commands - typescript-lsp.ts: TypeScript LSP helper with npm/yarn/pnpm commands Note: The popup UI rendering is stubbed (fires 'dismissed' immediately) and LSP disable doesn't persist to config yet. These require additional UI and config integration work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.