Add a french list of word #9
Closed
+336,827
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I recommend publishing it as a new package. I don't want to maintain a list of many languages and also because of the size of the word list, it makes sense as a separate package. |
Author
|
Ok make sense :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I made this PR to add the possibility to fetch and clean the French list of word.
I keep the same code has the previous version to keep backward compatibility and add two new possibility
{english, french}to be imported.Use case: I need to generate passphrase in French :)
If you d'on plan to merge this PR, I'm going to publish a new package on NPM with only the French word in it, with the name
word-list-frif it's ok for you.Have a great day !