SetFieldType: Add option to preserve property modifiers
#1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-sm
changed the title
SetFieldType: Add option to preserve property modifiers
|
@sindresorhus Noticed there's some room for improvement with index signatures as well. I'll create a separate PR for that because that'll require more complicated changes, so it's better to keep those changes separate. |
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1016
Adds a new
preservePropertyModifiersoption.I've set the default value of this option to
true, which means it'll regress from the existing behaviour, but that should be fine if the current behaviour is considered a bug.