Reserve room for the truncation character in preferTruncationOnSpace - #34
Merged
sindresorhus merged 1 commit intoJul 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preferTruncationOnSpacepicks the cut point assuming the truncation character occupies a single column. With a widertruncationCharacter(for example the common'...', width 3) the result exceedscolumns.The
startandendpreferTruncationOnSpacebranches hard-codelength - columns + 1andcolumns - 1, reserving a single column for the truncation character. The non-preferTruncationOnSpacepaths already reservestringWidth(truncationCharacter), and themiddlebranch already usestruncationWidth. This brings the two branches in line so the result stays withincolumns.With the default
'…'(width 1) the output is unchanged.Adds a regression test asserting
stringWidth(result) <= columnsforstart/end+preferTruncationOnSpacewith a multi-column truncation character.