Return the text unchanged when columns is NaN - #33
Closed
hong4rc wants to merge 1 commit into
Closed
Conversation
Owner
|
This should throw instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When
columnsisNaN, the input is returned with a truncation character always appended — so the output is longer than the input and nothing is actually truncated. It happens for any input, even an empty string:'''…''''hi''hi…''hi''unicorns''unicorns…''unicorns'Easy repro
How
NaNshows up in practiceThe common idiom of reserving a margin off the terminal width:
When stdout is not a TTY (piped to a file, redirected, or CI),
process.stdout.columnsisundefined, soundefined - 2isNaN:Fix
A
NaNbudget means the target width is unknown, so return the text untruncated instead of appending a truncation character. Other non-finite inputs are unchanged:Infinityalready returned the text, negatives already returned''.Added a
NaN columnstest (plain + ANSI-styled input).