Fixes for ShellExecutioner #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjonesy
commented
Oct 4, 2024
| @@ -18,7 +19,7 @@ const ( | |||
| DataEnvVarName = "GOVERSEER_DATA" | |||
|
|
|||
| // DefaultShell is the default shell to use when executing a command | |||
| DefaultShell = "/bin/sh" | |||
| DefaultShell = "/bin/sh -ec" | |||
There was a problem hiding this comment.
Setting a sane default here, -e makes it exit on error. -c tells sh to run the string of commands in a shell session.
ruffin
reviewed
Oct 4, 2024
cjonesy
commented
Oct 4, 2024
| @@ -146,8 +147,26 @@ func New(cfg config.Config) (*ShellExecutioner, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| func (e *ShellExecutioner) enableOutputStreaming(cmd *exec.Cmd) error { | |||
There was a problem hiding this comment.
The Execute function was getting crowded, moved this out to make it a bit easier to read.
Co-authored-by: Jonathan Ruffin <[email protected]>
ruffin
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for ShellExecutioner based on my experience using it more extensively.
.Close()on the pipe instead of letting it close itself (as indicated in the documentation of os/exec).INFO. It now logs correctly asERROR.panic: interface conversion: interface {} is time.Time, not string. The change channel isinterface{}, but I had always intended for this time value to be passed as a string.