Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters of repos.getContent API #89

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Dec 22, 2024

Closes #88

Fix the failing CI: https://github.com/simple-icons/simple-icons/actions/runs/12449683970/job/34766897205

I've tested the code on my local with npm run preview.

@LitoMore LitoMore force-pushed the fix-get-file-content branch from 3699e65 to bffcf26 Compare December 22, 2024 15:08
@LitoMore LitoMore requested a review from mondeja December 22, 2024 15:08
@LitoMore LitoMore force-pushed the fix-get-file-content branch from bffcf26 to 51d3a9f Compare December 22, 2024 15:12
@LitoMore LitoMore added the bug Something isn't working label Dec 22, 2024
@mondeja mondeja merged commit 4aaf082 into simple-icons:master Dec 22, 2024
3 checks passed
@mondeja
Copy link
Member

mondeja commented Dec 22, 2024

Released v1.3.1 but didn't worked, see https://github.com/simple-icons/simple-icons/actions/runs/12457034998/job/34771141728

Or we need to create a v1 tag? It seems that didn't exist before.

Reopened #88 just in case.

@LitoMore LitoMore deleted the fix-get-file-content branch December 22, 2024 19:50
@LitoMore
Copy link
Member Author

LitoMore commented Dec 22, 2024

You need to sync all changes to v1 branch. The v1 branch is used for release.

Passing now:

Never create a v1 tag, as this will cause the actions only to get the commit of the tag.

@mondeja
Copy link
Member

mondeja commented Dec 22, 2024

Ah, I see.

Never create a v1 tag, as this will cause the actions only to get the commit of the tag.

A lot of acions (all that I saw before in fact) just use a force push updating the tag. IMHO, branches has some drawbacks, for example, you need to maintain all major version branches and resolve conflicts on merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants