Fix for open redirect - identified in Issue 2429 #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 404 processing ends up redirecting a request with multiple path slashes to that site, i.e. https://my-site//shedcode.co.uk will redirect to https://shedcode.co.uk This commit uses a regular expression to remove the multiple leading slashes before redirecting.
jamesjefferies
changed the title
|
Ouch! Thanks for the report. I'll look at this today. |
|
Have you had chance to have a look yet @simonw ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 404 processing ends up redirecting a request with multiple path slashes to that site, i.e.
https://my-site//shedcode.co.uk will redirect to https://shedcode.co.uk
Identified in issue #2429
This commit uses a regular expression and a substitution to remove the multiple leading slashes before redirecting.
📚 Documentation preview 📚: https://datasette--2500.org.readthedocs.build/en/2500/