fix: support static files with spaces in their names #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browser encodes all non-ASCII characters in URL into percent encoding format. Static files are served from the filesystem, and can have unsafe characters in their names. To support such files the request `path` should be decoded.
|
It would be really nice to get this merged. This is an incredibly annoying bug. Every time I have to do a fork and patch the static handler, or rename every single file and deal with the duplication problems it causes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser encodes all non-ASCII characters in URL into percent encoding format.
Static files are served from the filesystem, and can have unsafe characters in their names.
To support such files the request
pathshould be decoded.📚 Documentation preview 📚: https://datasette--2450.org.readthedocs.build/en/2450/