Skip to content

Make primary key view accessible to render_cell hook #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make primary key view accessible to render_cell hook #2100

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43948f4
Make primary key view accessible to render_cell hook
Jul 13, 2023
82b8b94
Merge remote-tracking branch 'origin/main' into 1-make-link-column-am…
Jul 28, 2023
5639f9d
Merge remote-tracking branch 'upstream/main' into 1-make-link-column-…
Aug 10, 2023
a98450f
Merge tag '1.0a13' into 1-make-link-column-amenable-to-render_cell-hook
Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions datasette/views/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,24 @@ async def display_columns_and_rows(
if link_column:
is_special_link_column = len(pks) != 1
pk_path = path_from_row_pks(row, pks, not pks, False)

plugin_display_value = None
for candidate in pm.hook.render_cell(
row=row,
value=pk_path,
column='pk_path',
table=table_name,
database=database_name,
datasette=datasette,
request=request,
):
candidate = await await_me_maybe(candidate)
if candidate is not None:
plugin_display_value = candidate
break
if plugin_display_value:
pk_path = plugin_display_value

cells.append(
{
"column": pks[0] if len(pks) == 1 else "Link",
Expand Down