build(deps): bump sentry from 0.45.0 to 0.46.0 #352
clippy
9 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 9 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.92.0-beta.3 (f3f12444a 2025-11-09)
- cargo 1.92.0-beta.3 (344c4567c 2025-10-21)
- clippy 0.1.92 (f3f12444a0 2025-11-09)
Annotations
Check warning on line 221 in crates/gui2/src/lib.rs
github-actions / clippy
dereferencing a struct pattern where every field's pattern takes a reference
warning: dereferencing a struct pattern where every field's pattern takes a reference
--> crates/gui2/src/lib.rs:216:13
|
216 | / &AppState::Paused {
217 | | ref content,
218 | | ref breakpoints,
219 | | ref scrollable_id,
220 | | ..
221 | | } => CodeViewer::new(
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_borrowed_reference
= note: `#[warn(clippy::needless_borrowed_reference)]` on by default
help: try removing the `&` and `ref` parts
|
216 ~ AppState::Paused {
217 ~ content,
218 ~ breakpoints,
219 ~ scrollable_id,
|
Check warning on line 148 in crates/gui2/src/lib.rs
github-actions / clippy
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> crates/gui2/src/lib.rs:148:17
|
133 | / let debugger = match request.as_str() {
134 | | "attach" => {
135 | | let launch_arguments = AttachArguments {
136 | | working_directory: debug_root_dir.to_owned().to_path_buf(),
... |
146 | | _ => todo!(),
147 | | };
| |__________________- unnecessary `let` binding
148 | debugger
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
133 ~
134 ~ match request.as_str() {
135 + "attach" => {
136 + let launch_arguments = AttachArguments {
137 + working_directory: debug_root_dir.to_owned().to_path_buf(),
138 + port: connect.map(|c| c.port),
139 + language: debugger::Language::DebugPy,
140 + path_mappings,
141 + };
142 +
143 + tracing::debug!(?launch_arguments, "generated launch configuration");
144 +
145 + Debugger::new(launch_arguments).context("creating internal debugger")?
146 + }
147 + _ => todo!(),
148 + }
|
Check warning on line 5 in crates/gui2/src/highlight.rs
github-actions / clippy
struct `Highlighter` is never constructed
warning: struct `Highlighter` is never constructed
--> crates/gui2/src/highlight.rs:5:19
|
5 | pub(crate) struct Highlighter {
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
Check warning on line 260 in crates/pythondap/src/debugger.rs
github-actions / clippy
struct pattern is not needed for a unit variant
warning: struct pattern is not needed for a unit variant
--> crates/pythondap/src/debugger.rs:260:63
|
260 | .wait_for_event(|evt| matches!(evt, Event::Running { .. }));
| ^^^^^^^ help: remove the struct pattern
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#unneeded_struct_pattern
= note: `#[warn(clippy::unneeded_struct_pattern)]` on by default
Check warning on line 237 in crates/gui/src/main.rs
github-actions / clippy
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> crates/gui/src/main.rs:237:17
|
195 | / let debugger = match request.as_str() {
196 | | "attach" => {
197 | | let launch_arguments = AttachArguments {
198 | | working_directory: debug_root_dir.to_owned().to_path_buf(),
... |
235 | | _ => todo!(),
236 | | };
| |__________________- unnecessary `let` binding
237 | debugger
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
195 ~
196 ~ match request.as_str() {
197 + "attach" => {
198 + let launch_arguments = AttachArguments {
199 + working_directory: debug_root_dir.to_owned().to_path_buf(),
200 + port: connect.map(|c| c.port),
201 + language: debugger::Language::DebugPy,
202 + path_mappings,
203 + };
204 +
205 + tracing::debug!(?launch_arguments, "generated launch configuration");
206 +
207 + Debugger::new(launch_arguments).context("creating internal debugger")?
208 + }
209 + "launch" => {
210 + let Some(program) = program else {
211 + eyre::bail!("'program' is a required setting");
212 + };
213 + let launch_arguments = LaunchArguments {
214 + program: program.clone(),
215 + working_directory: Some(debug_root_dir.to_owned().to_path_buf()),
216 + language: debugger::Language::DebugPy,
217 + };
218 +
219 + tracing::debug!(?launch_arguments, "generated launch configuration");
220 + let debugger = debugger::Debugger::new(launch_arguments)
221 + .context("creating internal debugger")?;
222 +
223 + for line in args.breakpoints {
224 + let breakpoint = debugger::Breakpoint {
225 + path: program.clone(),
226 + line,
227 + ..Default::default()
228 + };
229 + debugger
230 + .add_breakpoint(&breakpoint)
231 + .context("adding breakpoint")?;
232 + }
233 +
234 + debugger
235 + }
236 + _ => todo!(),
237 + }
|
Check warning on line 36 in crates/gui/src/ui/call_stack.rs
github-actions / clippy
this `if` statement can be collapsed
warning: this `if` statement can be collapsed
--> crates/gui/src/ui/call_stack.rs:32:17
|
32 | / if ui.link(frame.name.to_string()).clicked() {
33 | | if let Err(e) = self.state.change_scope(frame.id) {
34 | | tracing::warn!(error = ?e, "error changing scope");
35 | | }
36 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
32 ~ if ui.link(frame.name.to_string()).clicked()
33 ~ && let Err(e) = self.state.change_scope(frame.id) {
34 | tracing::warn!(error = ?e, "error changing scope");
35 ~ }
|
Check warning on line 44 in crates/launch_configuration/src/lib.rs
github-actions / clippy
struct `Folder` is never constructed
warning: struct `Folder` is never constructed
--> crates/launch_configuration/src/lib.rs:44:8
|
44 | struct Folder {
| ^^^^^^
|
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
Check warning on line 43 in crates/server/src/debugpy.rs
github-actions / clippy
this can be `std::io::Error::other(_)`
warning: this can be `std::io::Error::other(_)`
--> crates/server/src/debugpy.rs:43:38
|
43 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#io_other_error
= note: `#[warn(clippy::io_other_error)]` on by default
help: use `std::io::Error::other`
|
43 - .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))
43 + .map_err(|e| std::io::Error::other(e))
|
Check warning on line 6 in crates/dap-codec/src/lib.rs
github-actions / clippy
enum `CodecError` is never used
warning: enum `CodecError` is never used
--> crates/dap-codec/src/lib.rs:6:6
|
6 | enum CodecError {
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default