chore: enforce consistency of translations in CI #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has grown out of looking to get the internationalization into a reproduce-able state. This is done by regenerating them through
intl_translationand running them through the formatter. This is a little cumbersome to do manually so I've introduced a justfile which combines these along with enforcing that no changes exist into a single command.This grew into throwing the most used commands into this justfile - at which point we may as well define the CI pipeline in it so we can run all the tests locally with a single command.
The final generated dart files are a bit different but 90% of the changes are double-quotes to single-quotes and removal of the trailing commas.