-
Notifications
You must be signed in to change notification settings - Fork 56
Handle x86 MSVC jumptables #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1superchip
wants to merge
14
commits into
simonlindholm:main
Choose a base branch
from
1superchip:x86-msvc-jumptable-fixup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7702f9b
Initial work for MSVC jumptables
1superchip d2e9d56
format diff.py
1superchip 65dae6d
Fix mypy
1superchip e905213
Update diff.py (remove `== True`)
1superchip 1b42422
Update diff.py (remove type annotation)
1superchip 742f4e0
Add explicit check for not None
1superchip bbe5487
Use Optional typing rather than Union
1superchip 0e43fb4
Remove search and replace
1superchip faa3f54
Fix removing lines within loop
1superchip e817af8
Fix formatting
1superchip 3e3c462
Do not catch interrupt exceptions `except Exception:`
1superchip a2cecc3
Replace tab with space
1superchip d40a9df
Specify objdump 2.39
1superchip 2463d3d
Merge remote-tracking branch 'upstream/main' into x86-msvc-jumptable-…
1superchip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it. I have the targets stored to it but they are never read from it.