Skip to content

Update dependency babel-plugin-ember-template-compilation to v3 #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

Update dependency babel-plugin-ember-template-compilation to v3 #1292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94949f0
Update dependency babel-plugin-ember-template-compilation to v3
renovate[bot] May 6, 2025
4ce3326
Upgrade babel and use experimental worker
wkillerud Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/ember-vite/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import ember from 'eslint-plugin-ember/recommended';
import prettier from 'eslint-plugin-prettier/recommended';
import n from 'eslint-plugin-n';

import babelParser from '@babel/eslint-parser';
import babelParser from '@babel/eslint-parser/experimental-worker';
Copy link
Collaborator

@wkillerud wkillerud Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel/babel#17341 (comment)

Copy link
Collaborator

@wkillerud wkillerud Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could wait for this worker to become stable before we upgrade the Ember plugin. I think it's fine to use this, seems to be working well.

Copy link
Owner

@simonihmig simonihmig Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkillerud thanks for looking into this! only took notice of that now...

Here is an attempt of the same upgrade in the app blueprint: ember-cli/ember-app-blueprint#9. Apparently running into the same problems.

The CI log files are not available anymore. Were your fixes working for you?

If so, this needs a rebase and fixing some merge conflicts. If not, should we close this for now and wait for this to get figured out?

Copy link
Collaborator

@wkillerud wkillerud Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely forgot about this 😅 I see there was a test failure, could be the screenshot tests. I'll rebase and try again.

Copy link
Collaborator

@wkillerud wkillerud Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works 👍


const parserOptions = {
esm: {
Expand Down
2 changes: 1 addition & 1 deletion apps/ember-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@rollup/plugin-babel": "6.0.4",
"@tsconfig/ember": "3.0.11",
"@types/node": "22.13.4",
"babel-plugin-ember-template-compilation": "2.4.1",
"babel-plugin-ember-template-compilation": "3.0.1",
"concurrently": "9.2.1",
"decorator-transforms": "2.3.0",
"ember-auto-import": "2.10.0",
Expand Down
Loading