-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HorizontalSliderWithBrowser: slider with play button #4176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it's a nice feature!
I left a few comments, mainly:
- Probably best to extend
HorizontalSliderWithBrowser
rather than using inheritance - Improve the play settings menu to be discoverable and only available on the play button.
src/silx/gui/widgets/FrameBrowser.py
Outdated
framerate = self.menu.getFrameRate() | ||
waiting_time_ms = int(1 / framerate * 1e3) | ||
self.__timer.start(waiting_time_ms) | ||
self.playButton.setIcon(icons.getQIcon("close")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A square "stop" icon would makes more sense, or keeping the button checked while playing and uncheck it at the end.
Thanks Thomas, yesterday a user asked me if it would be possible to export this 'movie' as a file to use it in presentations. What do you think? |
That sounds interesting! There's something like this in silx/src/silx/gui/plot3d/actions/io.py Line 192 in 1191989
It rotates the 3D scene and saves it as a list of *.png or as a .mng (the multi-image version of png). It's not the best output formats for videos (need to be converted), but it doesn't need extra dependencies ;). It would be good to output in a more common file format yet without a too cumbersome dependency.... |
I made a few propositions of changes in EdgarGF93#2 |
Update Play slider
Thanks, Thomas, looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Nice feature!
Checklist:
<Module or Topic>: <Action> <Summary>
(see contributing guidelines)This PR provides: