silx.utils.enum: Deprecated Enum.from_value method
#4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
commented
Jun 27, 2024
t20100
reviewed
Jun 27, 2024
|
@t20100 On second thought, I don't think it is worth deprecating the whole class just because So I only deprecated the |
loichuder
force-pushed
the
enum-doc
branch
2 times, most recently
from
cd12aaa to
0db75a3
Compare
t20100
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Looks good, thanks!
Usage of from_value throughout silx needs to be updated so silx does not generates deprecation warnings by itself.
|
Don't bother about the CI failure, it's a random one. |
t20100
changed the title
from_value methodEnum.from_value method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.