Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fixed support of PyInstaller v6 #4041

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Jan 10, 2024

This PR fixes the spec file which was no longer generating a working fat binary

closes #4040

@t20100 t20100 added this to the 2.0.0 milestone Jan 10, 2024
@t20100 t20100 requested a review from vasole January 10, 2024 09:29
@vasole
Copy link
Member

vasole commented Jan 10, 2024

There seem to be issues with the matplotlib backend tests under MacOS although they do not have anything to do with this PR.

@t20100
Copy link
Member Author

t20100 commented Jan 11, 2024

Yes, there's some issues with CI, it's next on my TODO list (#4032)

Copy link
Member

@vasole vasole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI errors have nothing to do with this PR.

@vasole vasole merged commit d608463 into silx-kit:main Jan 11, 2024
5 of 8 checks passed
@t20100 t20100 deleted the fix-pyinstaller branch January 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to generate Windows fat binary
2 participants