silx.gui.plot.PlotWidget: Improved text background rendering for OpenGL backend #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Dec 21, 2023
| @@ -907,7 +912,7 @@ def _lineStyleToDashOffsetPattern( | |||
| pattern = () | |||
| if len(pattern) == 2: | |||
| pattern = pattern * 2 | |||
| return offset, pattern | |||
| return float(offset), tuple(float(v) for v in pattern) | |||
There was a problem hiding this comment.
Not related to this PR but missing from adding int as a accepted type for line style.
t20100
commented
Dec 21, 2023
Comment on lines
+307
to
+310
| texCoords = numpy.array( | ||
| ( | ||
| (-xoffset, -yoffset), | ||
| (1.0 + xoffset, -yoffset), | ||
| (-xoffset, 1.0 + yoffset), | ||
| (1.0 + xoffset, 1.0 + yoffset), | ||
| ), | ||
| dtype=numpy.float32, |
There was a problem hiding this comment.
Extends texture coordinates, what's <0 or >1 is rendered with bgColor.
t20100
force-pushed
the
gl-text-padding
branch
from
a8874af to
182859e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation of PR #4011
This PR adds padding around text displayed by markers for the display of borders.
Instead of relying on 2 rendering as in PR #4011, it plays with the texture coordinates.