cython3 compatibility #4033
Merged
cython3 compatibility #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
approved these changes
Dec 21, 2023
| @@ -1,5 +1,11 @@ | |||
| #cython: embedsignature=True, language_level=3 | |||
| ## This is for optimisation | |||
| #cython: boundscheck=False, wraparound=False, cdivision=True, initializedcheck=False, | |||
| @@ -1,3 +1,8 @@ | |||
| #cython: embedsignature=True, language_level=3 | |||
| ## This is for optimisation | |||
| ##cython: boundscheck=False, wraparound=False, cdivision=True, initializedcheck=False, | |||
| @@ -101,7 +106,7 @@ ctypedef fused image_types: | |||
|
|
|||
| # Normalization | |||
|
|
|||
| ctypedef double (*NormalizationFunction)(double) nogil | |||
| # ctypedef double (*NormalizationFunction)(double) nogil | |||
There was a problem hiding this comment.
This is no longer a valid syntax?
There was a problem hiding this comment.
It is still valid but it is unused ... so I commented it to ensure nothing breaks.
To be removed once we are sure it makes no regression anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove compilation warnings
close #4019