Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antialiasing on opengl markers #4023

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Dec 20, 2023

Reworks few opengl markers to use distance function.
This allow to implement easily antialiasing and fix some floating point glitches.

Before

image

After

image

Changelog:

  • Fixes glitches on OpenGL marker rendering

@vallsv vallsv added this to the 2.0.0 milestone Dec 20, 2023
@vallsv vallsv requested a review from t20100 December 20, 2023 09:35
@vallsv vallsv self-assigned this Dec 20, 2023
@t20100
Copy link
Member

t20100 commented Dec 20, 2023

Looks good, thanks! smoothstep is not available in (old) GLSL 1.20 (OpenGL2.1).
You might end-up with OpenGL2.1 when running through ssh and I'm not sure what version of GLSL you get then.

smoothstep doc provides a corresponding alternative, let's use it.
I can take care of this.

@vallsv
Copy link
Contributor Author

vallsv commented Dec 20, 2023

BTW, smoothstep was already used by one of the symbols

@vallsv
Copy link
Contributor Author

vallsv commented Dec 20, 2023

smoothstep doc provides a corresponding alternative, let's use it. I can take care of this.

Yes please @t20100 if you know how to do it

@t20100 t20100 merged commit 7cde00d into silx-kit:main Dec 21, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants