Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silx.gui: Fixed PyQt6 support by not using deprecated qt.QPalette.Normal #3966

Merged
merged 1 commit into from
Nov 21, 2023
Merged

silx.gui: Fixed PyQt6 support by not using deprecated qt.QPalette.Normal #3966

merged 1 commit into from
Nov 21, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Nov 21, 2023

Replace qt.QPalette.Normal by qt.QPalette.Active to support pyqt6

closes #3962

@t20100 t20100 added this to the 2.0.0 milestone Nov 21, 2023
@t20100 t20100 requested a review from vasole November 21, 2023 14:35
@vasole
Copy link
Member

vasole commented Nov 21, 2023

Something escapes to me.

Why is QPalette.Active available and not QPalette.Normal when both are found as members of QPalette.ColorGroup?

@t20100
Copy link
Member Author

t20100 commented Nov 21, 2023

I guess it's because QPalette.Normal is deprecated (see https://doc.qt.io/qt-6/qpalette.html#ColorGroup-enum) but I don't really see the point.

@vasole vasole merged commit 92feec5 into silx-kit:main Nov 21, 2023
7 checks passed
@t20100 t20100 deleted the fix-qpalette-normal branch November 21, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasole vasole vasole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

[GUI] Colormap under PyQt6: QPalette has no attribute Normal
2 participants
@t20100 @vasole