silx.gui.utils.image: Added support of QImage.Format_Grayscale8 to convertQImageToArray
#3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependency with I am pretty sure there is dependency with at least |
+1, never checked I'd say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using grayscale8 QImage (available in Qt>=5.5) avoids some array copies/conversion when dealing with text in the OpenGL backend.
This moves minimum required version from Qt5.3 to Qt5.5... I documented minimum version to 5.6 ton Linux to be inline with Windows and macOS. BTW, we don't test with an old version of pyQt... so the effective min version requirement is probably higher.
Small improvement/clean-up done while working on PR #3956