Skip to content

Commit

Permalink
silx.gui.plot.actions.control: rename 'setColorDialog' to 'setColorma…
Browse files Browse the repository at this point in the history
…pDialog'
  • Loading branch information
payno committed Nov 16, 2023
1 parent 5371279 commit 4953e3a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/silx/gui/data/DataViews.py
Original file line number Diff line number Diff line change
Expand Up @@ -1657,7 +1657,7 @@ def createWidget(self, parent):
from silx.gui.data.NXdataWidgets import XYVScatterPlot
widget = XYVScatterPlot(parent)
widget.getScatterView().setColormap(self.defaultColormap())
widget.getScatterView().getScatterToolBar().getColormapAction().setColorDialog(
widget.getScatterView().getScatterToolBar().getColormapAction().setColormapDialog(
self.defaultColorDialog())
return widget

Expand Down
2 changes: 1 addition & 1 deletion src/silx/gui/plot/actions/control.py
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def __init__(self, plot, parent=None):
self.plot.sigActiveImageChanged.connect(self._updateColormap)
self.plot.sigActiveScatterChanged.connect(self._updateColormap)

def setColorDialog(self, colorDialog):
def setColormapDialog(self, colorDialog):
"""Set a specific color dialog instead of using the default dialog."""
assert(colorDialog is not None)
assert(self._dialog is None)
Expand Down

1 comment on commit 4953e3a

@vasole
Copy link
Member

@vasole vasole commented on 4953e3a Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate more conservative changes to the public API.

For instance, that breaks PyMca without any previous deprecation warning.

Please sign in to comment.