tom extracted method

silverqx · Aug 7, 2024 · 47de50b · 47de50b
1 parent de013ae
commit 47de50b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/tom/include/tom/application.hpp b/tom/include/tom/application.hpp
@@ -189,6 +189,10 @@ namespace Concerns
         /*! Get the command name including the guess command name logic. */
         QString getCommandName(const QString &name, CommandNotFound notFound);
 
+        /*! If passed non-existent command then show all commands list or error wall. */
+        [[noreturn]] void
+        handleEmptyCommandName(const QString &name, CommandNotFound notFound);
+
         /* Early exit during parse command-line */
         /*! Display the version information and exits. */
         [[noreturn]] void showVersion() const;

diff --git a/tom/src/tom/application.cpp b/tom/src/tom/application.cpp
@@ -412,27 +412,33 @@ QString Application::getCommandName(const QString &name, const CommandNotFound n
 
     // If passed a non-existent command then show all commands list or error wall
     if (commandName.isEmpty())
-        switch (notFound) {
-        T_LIKELY
-        case ShowCommandsList:
-            showCommandsList(EXIT_FAILURE);
+        handleEmptyCommandName(name, notFound); // [[noreturn]]
 
-        T_UNLIKELY
-        case ShowErrorWall:
-            errorWall(QStringLiteral("Command '%1' is not defined.").arg(name));
+    return commandName;
+}
+
+void Application::handleEmptyCommandName(const QString &name,
+                                         const CommandNotFound notFound)
+{
+    switch (notFound) {
+    T_LIKELY
+    case ShowCommandsList:
+        showCommandsList(EXIT_FAILURE);
+
+    T_UNLIKELY
+    case ShowErrorWall:
+        errorWall(QStringLiteral("Command '%1' is not defined.").arg(name));
 
-            exitApplication(EXIT_FAILURE);
+        exitApplication(EXIT_FAILURE);
 
-        default:
+    default:
 #ifndef TINYTOM_DEBUG
-            throw Exceptions::RuntimeError(
-                        sl("Unexpected value for enum struct CommandNotFound."));
+        throw Exceptions::RuntimeError(
+                    sl("Unexpected value for enum struct CommandNotFound."));
 #else
-            Q_UNREACHABLE();
+        Q_UNREACHABLE();
 #endif
-        }
-
-    return commandName;
+    }
 }
 
 /* Early exit during parse command-line */