revisited bugprone-exception-escape

include/orm/tiny/model.hpp

@@ -2227,7 +2227,6 @@ TINYORM_END_COMMON_NAMESPACE
 // BUG qmake, clang-cl (win32-clang-msvc) ctrl+shift+alt+b fails with: fatal error: PCH file 'debug\TinyOrm_pch.pch' not found: module file not found silverqx
 // BUG ccache, msvc and clang-cl support doesn't work because of /Zi param. https://github.com/ccache/ccache/issues/1040 silverqx
 // FUTURE security workflows, add ggshield https://github.com/GitGuardian/ggshield silverqx
-// BUG clang tidy reports bugprone-exception-escape for Model class, it doesn't mean that code is buggy or can crash, it means that some defualt method generated by the compiler that should be generated noexcet was generetad as throwing silverqx
 // CUR mariadb workflows silverqx
 // FEATURE HidesAttributes, and ModelsCollection::makeVisible/Hidden, ... silverqx
 // TODO vcpkg, workflows enable binary caching https://learn.microsoft.com/en-us/vcpkg/users/binarycaching#gha silverqx

tests/auto/functional/orm/tiny/model/tst_model.cpp

@@ -1802,8 +1802,7 @@ tst_Model::addTouch_setTouchedRelations_getTouchedRelations_touches_clearTouches
 
 namespace
 {
-    // NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-    class Role_WithoutUDates final : public Model<Role_WithoutUDates>
+    class Role_WithoutUDates final : public Model<Role_WithoutUDates> // NOLINT(bugprone-exception-escape, misc-no-recursion)
     {
         friend Model;
         using Model::Model;

tests/database/seeders/phoneseeder.hpp

@@ -9,8 +9,7 @@
 #ifndef TINYORM_DISABLE_ORM
 namespace Models
 {
-    // NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-    class Phone final : public Orm::Tiny::Model<Phone>
+    class Phone final : public Orm::Tiny::Model<Phone> // NOLINT(bugprone-exception-escape, misc-no-recursion)
     {
         using Model::Model;
     };

tests/models/models/album.hpp

@@ -18,8 +18,7 @@ using Orm::Tiny::Model;
 
 class AlbumImage;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class Album final : public Model<Album, AlbumImage>
+class Album final : public Model<Album, AlbumImage> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/albumimage.hpp

@@ -17,8 +17,7 @@ using Orm::Tiny::Model;
 
 class Album;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class AlbumImage final : public Model<AlbumImage, Album>
+class AlbumImage final : public Model<AlbumImage, Album> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/datetime.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Datetime final : public Model<Datetime>
+class Datetime final : public Model<Datetime> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/datetime_serializeoverride.hpp

@@ -11,8 +11,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Datetime_SerializeOverride final : public Model<Datetime_SerializeOverride>
+class Datetime_SerializeOverride final : public Model<Datetime_SerializeOverride> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/filepropertyproperty.hpp

@@ -13,8 +13,7 @@ using Orm::Tiny::Model;
 
 class TorrentPreviewableFileProperty;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class FilePropertyProperty final :
+class FilePropertyProperty final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<FilePropertyProperty, TorrentPreviewableFileProperty>
 {
     friend Model;

tests/models/models/massassignmentmodels.hpp

@@ -15,8 +15,7 @@ using Orm::Constants::SIZE_;
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Torrent_TotallyGuarded final : public Model<Torrent_TotallyGuarded>
+class Torrent_TotallyGuarded final : public Model<Torrent_TotallyGuarded> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;
@@ -25,8 +24,7 @@ class Torrent_TotallyGuarded final : public Model<Torrent_TotallyGuarded>
     QString u_table {"torrents"};
 };
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Torrent_GuardedAttribute final : public Model<Torrent_GuardedAttribute>
+class Torrent_GuardedAttribute final : public Model<Torrent_GuardedAttribute> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;
@@ -51,8 +49,7 @@ class Torrent_GuardedAttribute final : public Model<Torrent_GuardedAttribute>
     };
 };
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Torrent_AllowedMassAssignment final :
+class Torrent_AllowedMassAssignment final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<Torrent_AllowedMassAssignment>
 {
     friend Model;
@@ -65,8 +62,7 @@ class Torrent_AllowedMassAssignment final :
     inline static QStringList u_guarded {}; // disabled
 };
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Torrent_GuardableColumn final :
+class Torrent_GuardableColumn final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<Torrent_GuardableColumn>
 {
     friend Model;

tests/models/models/phone.hpp

@@ -13,8 +13,7 @@ using Orm::Tiny::Model;
 
 class User;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class Phone final : public Model<Phone, User>
+class Phone final : public Model<Phone, User> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/role.hpp

@@ -18,8 +18,7 @@ using Orm::Tiny::Relations::Pivot;
 
 class User;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class Role final : public Model<Role, User, RoleUser, RoleUser_Appends, Pivot>
+class Role final : public Model<Role, User, RoleUser, RoleUser_Appends, Pivot> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/roleuser.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Relations::BasePivot;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class RoleUser final : public BasePivot<RoleUser>
+class RoleUser final : public BasePivot<RoleUser> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     friend BasePivot;

tests/models/models/roleuser_appends.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Relations::BasePivot;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class RoleUser_Appends final : public BasePivot<RoleUser_Appends>
+class RoleUser_Appends final : public BasePivot<RoleUser_Appends> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     friend BasePivot;

tests/models/models/setting.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Setting final : public Model<Setting>
+class Setting final : public Model<Setting> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/tag.hpp

@@ -21,8 +21,7 @@ using Orm::Tiny::Model;
 class Role;
 class Torrent;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class Tag final : public Model<Tag, Torrent, TagProperty, Role, Tagged>
+class Tag final : public Model<Tag, Torrent, TagProperty, Role, Tagged> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 //class Tag final : public Model<Tag, Torrent, TagProperty, Role, Pivot>
 {
     friend Model;

tests/models/models/tag_returnrelation.hpp

@@ -14,8 +14,7 @@ using Orm::Tiny::Relations::Pivot;
 
 class Torrent_ReturnRelation;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class Tag_ReturnRelation final : public Model<Tag_ReturnRelation, Torrent_ReturnRelation,
+class Tag_ReturnRelation final : public Model<Tag_ReturnRelation, Torrent_ReturnRelation, // NOLINT(bugprone-exception-escape, misc-no-recursion)
                                               Pivot>
 {
     friend Model;

tests/models/models/tagged.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Relations::BasePivot;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Tagged final : public BasePivot<Tagged>
+class Tagged final : public BasePivot<Tagged> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     friend BasePivot;

tests/models/models/tagproperty.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TagProperty final : public Model<TagProperty>
+class TagProperty final : public Model<TagProperty> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/torrent.hpp

@@ -48,8 +48,7 @@ class TorrentPreviewableFile;
 class TorrentState;
 class User;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class Torrent final :
+class Torrent final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<Torrent, TorrentPreviewableFile, TorrentPeer, Tag, User,
                      TorrentState, Pivot>
 //        public Model<Torrent, TorrentPreviewableFile, TorrentPeer, Tag, User,

tests/models/models/torrent_returnrelation.hpp

@@ -23,8 +23,7 @@ class TorrentPeer;
 class TorrentPreviewableFile;
 class User;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class Torrent_ReturnRelation final :
+class Torrent_ReturnRelation final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<Torrent_ReturnRelation, TorrentPreviewableFile, TorrentPeer, Tag,
                      Tag_ReturnRelation, User, Pivot>
 {

tests/models/models/torrenteager.hpp

@@ -18,8 +18,7 @@ using Orm::Constants::SIZE_;
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentEager final : public Model<TorrentEager, TorrentPreviewableFileEager,
+class TorrentEager final : public Model<TorrentEager, TorrentPreviewableFileEager, // NOLINT(bugprone-exception-escape, misc-no-recursion)
                                         TorrentPeerEager_NoRelations>
 {
     friend Model;

tests/models/models/torrenteager_failed.hpp

@@ -11,8 +11,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentEager_Failed final :
+class TorrentEager_Failed final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<TorrentEager_Failed, TorrentPreviewableFileEager>
 {
     friend Model;

tests/models/models/torrenteager_withdefault.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentEager_WithDefault final : public Model<TorrentEager_WithDefault>
+class TorrentEager_WithDefault final : public Model<TorrentEager_WithDefault> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/torrenteager_without_qdatetime.hpp

@@ -15,8 +15,7 @@ using Orm::Constants::SIZE_;
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentEager_Without_QDateTime final : public Model<TorrentEager_Without_QDateTime>
+class TorrentEager_Without_QDateTime final : public Model<TorrentEager_Without_QDateTime> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/torrentpeer.hpp

@@ -13,8 +13,7 @@ using Orm::Tiny::Model;
 
 class Torrent;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class TorrentPeer final : public Model<TorrentPeer, Torrent>
+class TorrentPeer final : public Model<TorrentPeer, Torrent> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/torrentpeereager.hpp

@@ -11,8 +11,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentPeerEager final : public Model<TorrentPeerEager, TorrentEager>
+class TorrentPeerEager final : public Model<TorrentPeerEager, TorrentEager> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/torrentpeereager_norelations.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentPeerEager_NoRelations final : public Model<TorrentPeerEager_NoRelations>
+class TorrentPeerEager_NoRelations final : public Model<TorrentPeerEager_NoRelations> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/torrentpreviewablefile.hpp

@@ -22,8 +22,7 @@ using Orm::Tiny::Model;
 class Torrent;
 class TorrentPreviewableFileProperty;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class TorrentPreviewableFile final :
+class TorrentPreviewableFile final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<TorrentPreviewableFile, Torrent, TorrentPreviewableFileProperty>
 {
     friend Model;

tests/models/models/torrentpreviewablefileeager.hpp

@@ -15,8 +15,7 @@ using Orm::Constants::SIZE_;
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentPreviewableFileEager final :
+class TorrentPreviewableFileEager final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<TorrentPreviewableFileEager, TorrentPreviewableFilePropertyEager>
 {
     friend Model;

tests/models/models/torrentpreviewablefileeager_withdefault.hpp

@@ -17,8 +17,7 @@ using Orm::Constants::SIZE_;
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentPreviewableFileEager_WithDefault final :
+class TorrentPreviewableFileEager_WithDefault final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<TorrentPreviewableFileEager_WithDefault, TorrentEager_WithDefault,
                      TorrentPreviewableFilePropertyEager>
 {

tests/models/models/torrentpreviewablefileproperty.hpp

@@ -17,8 +17,7 @@ using Orm::Tiny::Model;
 class FilePropertyProperty;
 class TorrentPreviewableFile;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class TorrentPreviewableFileProperty final :
+class TorrentPreviewableFileProperty final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<TorrentPreviewableFileProperty, TorrentPreviewableFile,
                      FilePropertyProperty>
 {

tests/models/models/torrentpreviewablefilepropertyeager.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class TorrentPreviewableFilePropertyEager final :
+class TorrentPreviewableFilePropertyEager final : // NOLINT(bugprone-exception-escape, misc-no-recursion)
         public Model<TorrentPreviewableFilePropertyEager>
 {
     friend Model;

tests/models/models/torrentstate.hpp

@@ -16,8 +16,7 @@ using Orm::Tiny::Relations::Pivot;
 
 class Torrent;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class TorrentState final : public Model<TorrentState, Pivot>
+class TorrentState final : public Model<TorrentState, Pivot> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/type.hpp

@@ -9,8 +9,7 @@ namespace Models
 
 using Orm::Tiny::Model;
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
-class Type final : public Model<Type>
+class Type final : public Model<Type> // NOLINT(bugprone-exception-escape, misc-no-recursion)
 {
     friend Model;
     using Model::Model;

tests/models/models/user.hpp

@@ -23,8 +23,7 @@ class Phone;
 class Role;
 class Torrent;
 
-// NOLINTNEXTLINE(misc-no-recursion, bugprone-exception-escape)
-class User final : public Model<User, Phone, Role, Torrent, Pivot>,
+class User final : public Model<User, Phone, Role, Torrent, Pivot>, // NOLINT(bugprone-exception-escape, misc-no-recursion)
                    public SoftDeletes<User>
 {
     friend Model;

tom/include/tom/tomtypes.hpp

@@ -56,7 +56,7 @@ namespace Tom
     using Orm::Types::AboutValue;
 
     /*! Subsection item type. */
-    struct SubSectionItem // NOLINT(bugprone-exception-escape)
+    struct SubSectionItem // NOLINT(bugprone-exception-escape, misc-no-recursion)
     {
         /*! Subsection item name. */
         std::optional<QString> name;