renamed lsh/rhs to left/right

silverqx · Aug 5, 2022 · 07c76a9 · 07c76a9
1 parent 9e8c0ba
commit 07c76a9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/include/orm/tiny/tinytypes.hpp b/include/orm/tiny/tinytypes.hpp
@@ -50,7 +50,8 @@ namespace Relations
     };
 
     /*! Comparison operator for the AttributeItem. */
-    SHAREDLIB_EXPORT bool operator==(const AttributeItem &lhs, const AttributeItem &rhs);
+    SHAREDLIB_EXPORT bool
+    operator==(const AttributeItem &left, const AttributeItem &right);
 
     /*! Eager load relation item. */
     struct WithItem
@@ -61,7 +62,7 @@ namespace Relations
 
     /*! Comparison operator for the WithItem. */
     [[maybe_unused]]
-    SHAREDLIB_EXPORT bool operator==(const WithItem &lhs, const WithItem &rhs);
+    SHAREDLIB_EXPORT bool operator==(const WithItem &left, const WithItem &right);
 
     /*! Tag for Model::getRelation() family methods to return Related type
         directly ( not container type ). */

diff --git a/src/orm/tiny/tinytypes.cpp b/src/orm/tiny/tinytypes.cpp
@@ -10,14 +10,14 @@ AttributeItem::operator UpdateItem() const
     return {key, value};
 }
 
-bool operator==(const AttributeItem &lhs, const AttributeItem &rhs)
+bool operator==(const AttributeItem &left, const AttributeItem &right)
 {
-    return lhs.key == rhs.key && lhs.value == rhs.value;
+    return left.key == right.key && left.value == right.value;
 }
 
-bool operator==(const WithItem &lhs, const WithItem &rhs)
+bool operator==(const WithItem &left, const WithItem &right)
 {
-    return lhs.name == rhs.name;
+    return left.name == right.name;
 }
 
 } // namespace Orm::Tiny

diff --git a/tests/auto/functional/orm/tiny/model_conn_indep/tst_model_connection_independent.cpp b/tests/auto/functional/orm/tiny/model_conn_indep/tst_model_connection_independent.cpp
@@ -927,9 +927,9 @@ namespace
         QString name;
 
         /*! Comparison operator for the IdAndName. */
-        inline bool operator==(const IdAndName &other) const noexcept
+        inline bool operator==(const IdAndName &right) const noexcept
         {
-            return id == other.id && name == other.name;
+            return id == right.id && name == right.name;
         }
     };
 } // namespace