Add coding standard and update code to comply.

.editorconfig

@@ -0,0 +1,20 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+[*]
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+indent_style = space
+indent_size = 2
+
+[*.js]
+indent_style = space
+indent_size = 2
+
+[*.{diff,md}]
+trim_trailing_whitespace = false

.jscsrc

@@ -0,0 +1,59 @@
+{
+  "esnext": false,
+  "disallowSpacesInsideArrayBrackets": "all",
+  "disallowMultipleVarDecl": true,
+  "requireSpaceBeforeObjectValues": true,
+  "requireCommaBeforeLineBreak": true,
+  "requireBlocksOnNewline": 1,
+  "disallowKeywordsOnNewLine": ["else"],
+  "disallowNewlineBeforeBlockStatements": true,
+  "requireSpacesInConditionalExpression": {
+    "afterTest": true,
+    "beforeConsequent": true,
+    "afterConsequent": true,
+    "beforeAlternate": true
+  },
+  "disallowSpacesInCallExpression": true,
+  "disallowSpacesInsideParentheses": true,
+  "disallowEmptyBlocks": true,
+  "requireSpacesInsideObjectBrackets": "all",
+  "requireCurlyBraces": [
+    "if",
+    "else",
+    "for",
+    "while",
+    "do",
+    "try",
+    "catch"
+  ],
+  "requireLineFeedAtFileEnd": true,
+  "disallowTrailingWhitespace": true,
+  "disallowTrailingComma": true,
+  "requireSpaceBeforeBlockStatements": true,
+  "validateIndentation": 2,
+  "validateLineBreaks": "LF",
+  "validateParameterSeparator": ", ",
+  "validateQuoteMarks": {
+    "mark": "'",
+    "escape": true
+  },
+  "requireSpaceBeforeKeywords": [
+    "else",
+    "while",
+    "catch"
+  ],
+  "requireSpaceAfterKeywords": [
+    "do",
+    "for",
+    "if",
+    "else",
+    "switch",
+    "case",
+    "try",
+    "while",
+    "with",
+    "return"
+  ],
+  "requireSpaceBetweenArguments": true,
+  "requireSpaceAfterLineComment": true
+}

.jshintrc

@@ -0,0 +1,27 @@
+{
+  "browser": false,
+  "boss": true,
+  "curly": true,
+  "debug": false,
+  "devel": true,
+  "eqeqeq": true,
+  "evil": true,
+  "forin": false,
+  "immed": false,
+  "laxbreak": false,
+  "newcap": true,
+  "noarg": true,
+  "node": true,
+  "noempty": false,
+  "nonew": false,
+  "nomen": false,
+  "onevar": false,
+  "plusplus": false,
+  "regexp": false,
+  "undef": true,
+  "sub": true,
+  "strict": false,
+  "white": false,
+  "eqnull": true,
+  "unused": true
+}

lib/clean.js

@@ -3,14 +3,13 @@
 var fs = require('fs');
 var gutil = require('gulp-util');
 var paths = require('./paths');
-var utils = require('./utils');
 var flags = require('./flags');
 
 function deleteFolderRecursive(path, progress) {
 	var files = [];
 	if (fs.existsSync(path)) {
 		files = fs.readdirSync(path);
-		files.forEach(function(file, index) {
+		files.forEach(function(file) {
 			var curPath = path + '/' + file;
 			if (fs.lstatSync(curPath).isDirectory()) {
 				deleteFolderRecursive(curPath, progress);

lib/phplint.js

@@ -2,13 +2,13 @@
 
 var gulp = require('gulp');
 var gutil = require('gulp-util');
-var Spawn = require('gulp-spawn');
+var gulpSpawn = require('gulp-spawn');
 var Stream = require('stream');
 
 var paths = require('./paths');
 
 var spawn = function() {
-	return Spawn({
+	return gulpSpawn({
 		cmd: 'php',
 		args: [ '-l' ]
 	});
@@ -45,7 +45,7 @@ var filter = function(error, err) {
 
 		this.push(file);
 		done();
-	}
+	};
 
 	return stream;
 };

lib/symlinks.js

@@ -14,7 +14,7 @@ var paths = require('./paths');
  * instead of installed PEAR packages
  */
 var setup = function(err, progress, complete) {
-	fs.readdirSync(paths.packages).forEach(function(packageName, index) {
+	fs.readdirSync(paths.packages).forEach(function(packageName) {
 		var packageLinkPath = path.join(paths.packages, packageName);
 		if (fs.lstatSync(packageLinkPath).isSymbolicLink()) {
 			var packageRealPath = path.join(
@@ -25,16 +25,17 @@ var setup = function(err, progress, complete) {
 				'www'
 			);
 
-			if (   fs.existsSync(packageRealPath)
-				&& (
-					   !fs.existsSync(packageLinkPath)
-					|| packageRealPath != fs.realpathSync(packageLinkPath)
+			if (fs.existsSync(packageRealPath) &&
+				(
+					!fs.existsSync(packageLinkPath) ||
+					packageRealPath !== fs.realpathSync(packageLinkPath)
 				)
 			) {
 				fs.unlinkSync(packageLinkPath);
 				fs.symlinkSync(packageRealPath, packageLinkPath);
 				if (progress) {
-					progress(packageName,
+					progress(
+						packageName,
 						packageLinkPath,
 						packageRealPath
 					);
@@ -55,7 +56,7 @@ var setup = function(err, progress, complete) {
 var teardown = function(err, progress, complete) {
 	function getPathList(dir, cwd) {
 		var pathList = [];
-		fs.readdirSync(dir).forEach(function(packageName, index) {
+		fs.readdirSync(dir).forEach(function(packageName) {
 			var packageLinkPath = path.join(dir, packageName);
 			if (fs.lstatSync(packageLinkPath).isSymbolicLink()) {
 				// Need to get the relative path for git checkout
@@ -71,7 +72,7 @@ var teardown = function(err, progress, complete) {
 	function revert(pathList) {
 		var cmd = 'git checkout -- ' + pathList.join(' ');
 		var deferred = q.defer();
-		child_process.exec(cmd, {}, function(code, stdout, stderr) {
+		child_process.exec(cmd, {}, function() {
 			if (complete) {
 				complete();
 			}
@@ -91,7 +92,7 @@ module.exports = {
 		gutil.log(gutil.colors.blue('Restoring symlinks for www/packages:'));
 		return this.teardown(
 			err,
-			function (packageName, packageLinkPath, packageRealPath) {
+			function (packageName) {
 				gutil.log(gutil.colors.gray('..'), packageName);
 			},
 			function () {
@@ -104,7 +105,7 @@ module.exports = {
 			gutil.log(gutil.colors.blue('Updating symlinks for www/packages:'));
 			return setup(
 				null,
-				function (packageName, packageLinkPath, packageRealPath) {
+				function (packageName) {
 					gutil.log(gutil.colors.gray('..'), packageName);
 				},
 				function () {
@@ -118,7 +119,7 @@ module.exports = {
 			);
 			return teardown(
 				null,
-				function (packageName, packageLinkPath, packageRealPath) {
+				function (packageName) {
 					gutil.log(gutil.colors.gray('..'), packageName);
 				},
 				function () {

lib/utils.js

@@ -1,8 +1,6 @@
 'use strict';
 
 var fs = require('fs');
-var flags = require('./flags');
-var symlinks = require('./symlinks');
 
 module.exports = {
 	deleteIfExists: function (path) {