-
Notifications
You must be signed in to change notification settings - Fork 4
[NO-TKT] Dependency Updates #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
louisvdaily
wants to merge
4
commits into
master
Choose a base branch
from
dependency-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ version: 2 | |
| jobs: | ||
| unit-test: | ||
| macos: | ||
| xcode: "11.4.1" | ||
| xcode: "12.0.0" | ||
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| github "mxcl/PromiseKit" "6.10.0" | ||
| github "PromiseKit/Foundation" "3.3.3" | ||
| github "mxcl/PromiseKit" ~> 6.10.0 | ||
| github "PromiseKit/Foundation" ~> 3.3.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| github "AliSoftware/OHHTTPStubs" "8.0.0" | ||
| github "Quick/Quick" | ||
| github "Quick/Nimble" | ||
| github "Quick/Quick" ~> 3.0.0 | ||
| github "Quick/Nimble" ~> 9.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| github "AliSoftware/OHHTTPStubs" "8.0.0" | ||
| github "PromiseKit/Foundation" "3.3.3" | ||
| github "Quick/Nimble" "v8.0.4" | ||
| github "Quick/Quick" "v2.2.0" | ||
| github "mxcl/PromiseKit" "6.10.0" | ||
| github "PromiseKit/Foundation" "3.3.4" | ||
| github "Quick/Nimble" "v9.0.0" | ||
| github "Quick/Quick" "v3.0.0" | ||
| github "mxcl/PromiseKit" "6.13.3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/bin/sh | ||
|
|
||
| carthage bootstrap --platform ios | ||
| ./carthage.sh bootstrap --platform ios | ||
| cp Cartfile.resolved Carthage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # carthage.sh | ||
| # Usage example: ./carthage.sh build --platform iOS | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| xcconfig=$(mktemp /tmp/static.xcconfig.XXXXXX) | ||
| trap 'rm -f "$xcconfig"' INT TERM HUP EXIT | ||
|
|
||
| # For Xcode 12 make sure EXCLUDED_ARCHS is set to arm architectures otherwise | ||
| # the build will fail on lipo due to duplicate architectures. | ||
| echo 'EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_1200 = arm64 arm64e armv7 armv7s armv6 armv8' >> $xcconfig | ||
| echo 'EXCLUDED_ARCHS = $(inherited) $(EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_$(EFFECTIVE_PLATFORM_SUFFIX)__NATIVE_ARCH_64_BIT_$(NATIVE_ARCH_64_BIT)__XCODE_$(XCODE_VERSION_MAJOR))' >> $xcconfig | ||
|
|
||
| export XCODE_XCCONFIG_FILE="$xcconfig" | ||
| carthage "$@" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to generate the list of architectures here instead of hardcoding it (or at least can you move it to a "constant" variable defined at the top of the file?
Given this needs to be an explicit exclusion list I presume it would break if a new architecture were to be added, which might lead to future maintenance overhead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the comment made by my friend Oliver about avoiding hardcoding, as it's difficult to maintain the code in the long run.