-
-
Notifications
You must be signed in to change notification settings - Fork 5
SF-3642 Fix the button text color for the report a problem button #3579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3579 +/- ##
=======================================
Coverage 82.78% 82.78%
=======================================
Files 608 608
Lines 37196 37196
Branches 6102 6078 -24
=======================================
Hits 30794 30794
Misses 5488 5488
Partials 914 914 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RaymondLuong3 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)
src/SIL.XForge.Scripture/ClientApp/src/app/shared/notice/notice.component.scss line 151 at r1 (raw file):
.mat-mdc-icon-button { // use the correct icon button color from the theme color: var(--notice-color-text);
I don't see where this is used. Is it necessary?
Code quote:
color: var(--notice-color-text);
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3)
src/SIL.XForge.Scripture/ClientApp/src/app/shared/notice/notice.component.scss line 151 at r1 (raw file):
Previously, RaymondLuong3 (Raymond Luong) wrote…
I don't see where this is used. Is it necessary?
It is used on the draft jobs screen for the close icon on the filter notice:
42cea82 to
b5e2d7b
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)
src/SIL.XForge.Scripture/ClientApp/src/app/shared/notice/notice.component.scss line 151 at r1 (raw file):
Previously, pmachapman (Peter Chapman) wrote…
It is used on the draft jobs screen for the close icon on the filter notice:
Thanks for the explanation.

This button fixes a regression from #3511 where a style that was supposed to correctly theme an icon button in a notice themed text buttons as well.
This change is