Skip to content

Conversation

@RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Nov 18, 2025

This PR updates the logic to calculate whether the server should try to update the project draft status. Previously it would try to update the status if any chapter of a book that should have a draft was false. This change updates the logic to only update the draft status if all chapters hasDraft are set to false. This handles the case when a draft uses a source that does not have all the chapters and 1 or more chapters does not produce a draft.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.80%. Comparing base (197f24b) to head (bb557c3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3576   +/-   ##
=======================================
  Coverage   82.79%   82.80%           
=======================================
  Files         608      608           
  Lines       37147    37147           
  Branches     6065     6089   +24     
=======================================
+ Hits        30757    30758    +1     
  Misses       5478     5478           
+ Partials      912      911    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman
Copy link
Collaborator

I think that PR #3574 fixes this bug? I solved it there by storing a list of the current draft books as a scripture range, and deprecating HasDraft.

@RaymondLuong3
Copy link
Collaborator Author

Thanks! Yes, I see that is likely to resolve this issue. I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants