Skip to content

Conversation

@josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Nov 10, 2025

This allows the error text to occupy more layout than one line. Fixes a layout bug on small screens.


This change is Reviewable

@josephmyers josephmyers added the will require testing PR should not be merged until testers confirm testing is complete label Nov 10, 2025
@josephmyers josephmyers marked this pull request as ready for review November 10, 2025 19:34
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.80%. Comparing base (142f019) to head (5fe1271).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3567   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files         608      608           
  Lines       37201    37201           
  Branches     6104     6104           
=======================================
  Hits        30803    30803           
  Misses       5472     5472           
  Partials      926      926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like how this kills the padding below the project select field, for example on the configure sources page. Is there a way to have a minimum padding below the project select, matching the old passing?

i.e.
Master:
image.png

This PR:
image copy 1.png

Source: https://www.chromatic.com/test?appId=644bffe327c540a62f0fd260&id=69123f338977d9fbbde4e4b4

@pmachapman reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @josephmyers)

@Nateowami
Copy link
Collaborator

@josephmyers Please update the title to follow the guidelines for commit messages:

  • Explain what changed, not how it changed
    • The summary should explain what happens from a user's perspective, not what you did to fix a bug

@josephmyers josephmyers force-pushed the fix/SF-3177 branch 2 times, most recently from ba70435 to cb7db81 Compare November 17, 2025 14:41
Copy link
Collaborator Author

@josephmyers josephmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to get a min padding or margin to work, so I settled for an ng-deep on the subscript wrapper. Let me know what you think

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pmachapman)

@josephmyers josephmyers changed the title SF-3177 Add dynamic subscript sizing to project field SF-3177 Add dynamic error text sizing to project select Nov 17, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @josephmyers)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Nov 17, 2025
@pmachapman pmachapman self-assigned this Nov 18, 2025
This allows the error text to occupy more layout than one line. Fixes a layout bug on small screens.
@Nateowami Nateowami changed the title SF-3177 Add dynamic error text sizing to project select SF-3177 Fix error message text overlap in draft import dialog Nov 19, 2025
@RaymondLuong3 RaymondLuong3 merged commit e0fd2f4 into master Nov 20, 2025
23 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3177 branch November 20, 2025 15:26
@Nateowami
Copy link
Collaborator

@josephmyers SF-3177 Add dynamic error text sizing to project select is not a clear message for anyone that isn't familiar with the issue to begin with. A more appropriate title for a bug fix is something like Fix <description of issue>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants