-
-
Notifications
You must be signed in to change notification settings - Fork 5
SF-3177 Fix error message text overlap in draft import dialog #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3567 +/- ##
=======================================
Coverage 82.80% 82.80%
=======================================
Files 608 608
Lines 37201 37201
Branches 6104 6104
=======================================
Hits 30803 30803
Misses 5472 5472
Partials 926 926 ☔ View full report in Codecov by Sentry. |
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like how this kills the padding below the project select field, for example on the configure sources page. Is there a way to have a minimum padding below the project select, matching the old passing?
Source: https://www.chromatic.com/test?appId=644bffe327c540a62f0fd260&id=69123f338977d9fbbde4e4b4
@pmachapman reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @josephmyers)
|
@josephmyers Please update the title to follow the guidelines for commit messages:
|
ba70435 to
cb7db81
Compare
josephmyers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to get a min padding or margin to work, so I settled for an ng-deep on the subscript wrapper. Let me know what you think
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pmachapman)
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @josephmyers)
This allows the error text to occupy more layout than one line. Fixes a layout bug on small screens.
cb7db81 to
5fe1271
Compare
|
@josephmyers |


This allows the error text to occupy more layout than one line. Fixes a layout bug on small screens.
This change is