Skip to content

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Sep 25, 2025

Putting the notice banner on its own line is the sensible solution here.


This change is Reviewable

@josephmyers josephmyers added the will require testing PR should not be merged until testers confirm testing is complete label Sep 25, 2025
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.18%. Comparing base (6c3aa27) to head (1501639).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3468   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files         611      611           
  Lines       36441    36441           
  Branches     6005     6000    -5     
=======================================
  Hits        29950    29950           
  Misses       5610     5610           
  Partials      881      881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @josephmyers)

@Nateowami
Copy link
Collaborator

@josephmyers In the future can you include the issue number in the commit message? That way GitHub automatically links it to the Jira issue and it make it easy to jump to the associated issue.

@Nateowami Nateowami added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Sep 25, 2025
@Nateowami Nateowami self-assigned this Sep 25, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Sep 26, 2025
Putting the notice banner on its own line is the sensible solution here.
@Nateowami Nateowami enabled auto-merge (squash) September 26, 2025 13:40
@Nateowami Nateowami merged commit 7209dc2 into master Sep 26, 2025
23 checks passed
@Nateowami Nateowami deleted the fix/SF-3569 branch September 26, 2025 13:49
@josephmyers
Copy link
Collaborator Author

I will try to remember this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing complete Testing of PR is complete and should no longer hold up merging of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants