Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
9c4c805
Dispose realtime docs when no longer in use
Nateowami Aug 6, 2025
21daae0
await realtimeService.get
marksvc Aug 28, 2025
e31158d
await realtimeService.get
marksvc Aug 28, 2025
dae5188
add name arg to realtimeService.subscribeQuery
marksvc Aug 28, 2025
4ea6721
await
marksvc Aug 28, 2025
ca9ca04
await
marksvc Aug 28, 2025
4bcd91d
onlineQuery name
marksvc Aug 28, 2025
fa14e13
await, name
marksvc Aug 28, 2025
598dab2
await
marksvc Aug 28, 2025
7f800fa
await realtimeService.get
marksvc Aug 28, 2025
b08eef0
async
marksvc Aug 28, 2025
6487df2
await, 'spec'
marksvc Aug 29, 2025
83e40af
await, 'spec'
marksvc Aug 29, 2025
760f89a
async
marksvc Aug 29, 2025
e612435
await
marksvc Aug 29, 2025
4c19d85
question-dialog specs: await
marksvc Sep 9, 2025
12828a0
Question dialog spec private
marksvc Sep 9, 2025
fe37bac
draft sources component spec await
marksvc Sep 9, 2025
589ee87
fix tests in sync-progress.component
marksvc Sep 10, 2025
14f02ec
fix tests in checking-overview.component
marksvc Sep 10, 2025
7f7e038
fix tests in lynx-workspace.service
marksvc Sep 10, 2025
b3521ca
fix tests for sync.component
marksvc Sep 10, 2025
65b19ce
fix most of app.component.spec
marksvc Sep 10, 2025
7b2802f
adjust permissions service spec
marksvc Sep 10, 2025
9cdc50c
fix tests in connect-project.component
marksvc Sep 10, 2025
be521d1
fix most of the tests in editor.component
marksvc Sep 10, 2025
c6afedb
some fixes to share dialog component
marksvc Sep 12, 2025
8370c61
share dialog - overlayContainer.ngOnDestroy
marksvc Sep 12, 2025
ab494e6
fix share dialog component tests
marksvc Sep 12, 2025
544ffdc
fix tests in translate overview component
marksvc Sep 12, 2025
67786a1
permissions service tests - fix injection errors about httpclient and…
marksvc Sep 15, 2025
def5161
fix permissions service spec by adding mockSFUserProjectsService
marksvc Sep 15, 2025
008194c
checking component spec some fixes
marksvc Sep 15, 2025
fb489cb
checking spec await
marksvc Sep 15, 2025
db06ef6
checking component spec await
marksvc Sep 15, 2025
ec1ce99
checking component spec await
marksvc Sep 15, 2025
24f283f
use jasmine spyOn instead of ts-mockito spy for questionDoc
marksvc Sep 16, 2025
27a34b2
app componet spec await
marksvc Sep 16, 2025
632d069
fix after rebase
marksvc Sep 16, 2025
ee5adf0
fix lynx tests after rebase
marksvc Sep 16, 2025
3058f2e
Fix after rebase
marksvc Sep 17, 2025
b26463a
Fix what ain't broke. Apply await patterns in other spec files
marksvc Sep 17, 2025
e08bb18
Ignore resolveNote test
marksvc Sep 26, 2025
d59fd6c
fix after rebase
marksvc Sep 26, 2025
3d6fe33
Fix paths to xforge-common
marksvc Sep 26, 2025
b26855a
Fixes after rebase
marksvc Sep 26, 2025
e0a19f4
Fix after rebase
marksvc Sep 26, 2025
4f4bed0
Fix draft-generation-steps spec
marksvc Sep 26, 2025
a32e934
Revert "fix share dialog component tests"
marksvc Sep 29, 2025
582c259
better log test command, better capture output
marksvc Sep 29, 2025
52e5564
rm log message
marksvc Sep 29, 2025
1edbc64
ci: increase e2e startup polling delay
marksvc Sep 29, 2025
ee4df26
ci: make error more clear
marksvc Sep 29, 2025
6fc82f5
rm more console.log (failing tests)
marksvc Sep 29, 2025
09f3527
Add error message clarity
marksvc Sep 30, 2025
26f7abc
Bump up e2e attempts for generate_draft
marksvc Sep 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,13 @@ jobs:
# Run the tests while making sure none of the common/known warnings are printed
- name: "Test: Frontend"
run: |
set -euo pipefail
set -xeuo pipefail
cd src/SIL.XForge.Scripture/ClientApp
npm run test:gha | tee test_output.log
! grep -P 'NG\d+|ERROR:|WARN:|LOG:|INFO:' test_output.log
npm run test:gha |& tee test_output.log
if grep --perl-regex 'NG\d+|ERROR:|WARN:|LOG:|INFO:' test_output.log; then
echo "Error: Disallowed token found in test run output, as shown above.";
exit 1;
fi

- name: "Coverage: Backend"
run: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// or exits with a failure if it hasn't started in 5 minutes.

const pollUrl = 'http://localhost:5000/projects';
const pollInterval = 1000;
const pollInterval = 17000;
const timeout = 5 * 60_000;

setTimeout(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/SIL.XForge.Scripture/ClientApp/e2e/presets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@ export const presets = {
defaultUserDelay: 0,
showArrow: true,
outputDir: 'test_output/ci_e2e_test_results',
maxTries: 5
maxTries: 50
}
} as const satisfies { [key: string]: TestPreset };
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"failure": 0
},
"generate_draft": {
"success": 13,
"failure": 0
"success": 1,
"failure": 100
},
"community_checking": {
"success": 13,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ async function joinAsChecker(
// Give time for the last answer to be saved
await page.waitForTimeout(500);
} catch (e) {
await page.pause();
console.error('Error running tests for checker ' + userNumber);
console.error(e);
await screenshot(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { ServalAdminAuthGuard } from './serval-administration/serval-admin-auth.
import { ServalAdministrationComponent } from './serval-administration/serval-administration.component';
import { ServalProjectComponent } from './serval-administration/serval-project.component';
import { SettingsComponent } from './settings/settings.component';
import { BlankPageComponent } from './shared/blank-page/blank-page.component';
import { PageNotFoundComponent } from './shared/page-not-found/page-not-found.component';
import { SettingsAuthGuard, SyncAuthGuard } from './shared/project-router.guard';
import { SyncComponent } from './sync/sync.component';
Expand All @@ -33,6 +34,7 @@ const routes: Routes = [
{ path: 'serval-administration/:projectId', component: ServalProjectComponent, canActivate: [ServalAdminAuthGuard] },
{ path: 'serval-administration', component: ServalAdministrationComponent, canActivate: [ServalAdminAuthGuard] },
{ path: 'system-administration', component: SystemAdministrationComponent, canActivate: [SystemAdminAuthGuard] },
{ path: 'blank-page', component: BlankPageComponent },
{ path: '**', component: PageNotFoundComponent }
];

Expand Down
Loading
Loading