SF-3084 Fix checking overview page not showing questions correctly #2959
+39
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaymondLuong3
added
the
will require testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2959 +/- ##
==========================================
- Coverage 82.00% 82.00% -0.01%
==========================================
Files 544 544
Lines 31645 31643 -2
Branches 5129 5128 -1
==========================================
- Hits 25952 25949 -3
Misses 4929 4929
- Partials 764 765 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the overview page, the user was wrongly being shown that questions were loading when they were offline. This is because the questionQuery.ready property never returns true if offline. However, the query results will still load the offline docs. This change adds checking for the online status and only shows the loading message if the user is online.
This change is