Removed temp model dir, reworked save-checkpoints #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminking
approved these changes
Nov 21, 2025
Collaborator
benjaminking
left a comment
benjaminking
left a comment
There was a problem hiding this comment.
This should simplify things substantially. I like it.
@benjaminking reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mshannon-sil)
mshannon-sil
approved these changes
Nov 24, 2025
Collaborator
mshannon-sil
left a comment
mshannon-sil
left a comment
There was a problem hiding this comment.
Assuming you've run it and not experienced any lag issues with temporary checkpoints being deleted in the S3 bucket, then
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoints are now always stored in the default location (on the mount) and are only deleted if
--save-checkpointsis not included.This change is