Skip to content

Properly preserve specified markers (matching fix in machine) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Mar 27, 2025

Fixes #166


This change is Reviewable

@Enkidu93
Copy link
Collaborator Author

This was the 'small fix' I mentioned in Tuesday's meeting that might be the only inconsistency between Serval & silnlp.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (7cea3f5) to head (c7a6ca1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   88.53%   88.55%   +0.01%     
==========================================
  Files         276      276              
  Lines       16489    16498       +9     
==========================================
+ Hits        14599    14609      +10     
+ Misses       1890     1889       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @isaac091 and @johnml1135)

Copy link
Collaborator

@isaac091 isaac091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@Enkidu93 Enkidu93 merged commit 10a0dca into main Mar 27, 2025
14 checks passed
@Enkidu93 Enkidu93 deleted the fix_preserve_paragraph_styles branch March 27, 2025 16:41
@Enkidu93
Copy link
Collaborator Author

@isaac091 Should I go ahead and release a new machine library version & then you can update the dependency in silnlp? Or what needs to be done to get this change integrated into silnlp?

@isaac091
Copy link
Collaborator

Yeah, that would be great! I'm already making another round of updates to what will be the affected code anyway.

@Enkidu93
Copy link
Collaborator Author

Yeah, that would be great! I'm already making another round of updates to what will be the affected code anyway.

Should be released now, @isaac091. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix preserve paragraph styles in machine.py
4 participants