-
-
Notifications
You must be signed in to change notification settings - Fork 2
Properly preserve specified markers (matching fix in machine) #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was the 'small fix' I mentioned in Tuesday's meeting that might be the only inconsistency between Serval & silnlp. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01%
==========================================
Files 276 276
Lines 16489 16498 +9
==========================================
+ Hits 14599 14609 +10
+ Misses 1890 1889 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @isaac091 and @johnml1135)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
@isaac091 Should I go ahead and release a new machine library version & then you can update the dependency in silnlp? Or what needs to be done to get this change integrated into silnlp? |
Yeah, that would be great! I'm already making another round of updates to what will be the affected code anyway. |
Should be released now, @isaac091. Thank you! |
Fixes #166
This change is