Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project page now shows "Ask to join project" button for org members #1390

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Jan 17, 2025

Fixes #1153.

Org members who aren't yet project members can ask to join a project by clicking the button, which will send an email to project managers.

image

Pops up a persistent notification that won't time out:

image

Org members who aren't yet project members can ask to join a project by
clicking the button, which will send an email to project managers.
@rmunn rmunn requested a review from hahn-kev January 17, 2025 19:59
Copy link

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 28087b2. ± Comparison against base commit 30c8d5a.

Copy link

C# Unit Tests

104 tests  ±0   104 ✅ ±0   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 28087b2. ± Comparison against base commit 30c8d5a.

@rmunn
Copy link
Contributor Author

rmunn commented Jan 17, 2025

One issue that came up when I tested it, but shouldn't arise in production: the elawa project, at the time I tested this, had no members and so there was nobody to send the email to, yet the notification falsely told the user that the project managers had been emailed. However, in production we have a rule that projects without managers aren't allowed, so I think it's safe to ignore that situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow org members to join existing org projects
1 participant