Log exception messages on .NET 6+ when dynamic library loading fails #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
reviewed
Aug 20, 2024
lyonsil
force-pushed
the
log-exception-message
branch
from
82a2d0b to
18fdf35
Compare
hahn-kev
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS the only way to get detailed error information about library loading is through the exception message. According to the
manpage fordlopen, the way to get detailed error information is through callingdlerror. We can't do that directly in .NET on macOS because thelibdldoesn't exist anymore. So .NET has to do it for us under the covers and pass the results through the exception message. We've been throwing that away.This isn't an urgent fix by any means, but it is something we should include in our logging.