-
-
Notifications
You must be signed in to change notification settings - Fork 2
TT-6878 Navigating home after team deletion on that team's page #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-44
Are you sure you want to change the base?
Conversation
- Added a new renderer instructions file to guide agents through the architecture and startup flow of the app. - Implemented the ProjectsScreen and TeamsScreen components with responsive layouts and mobile-friendly interactions. - Created utility functions for route management and navigation, enhancing the user experience across devices. - Split the old home screen into two pages, where the latter (viewing a team's projects) is now considered "home"
- logic to go to team screen - desktop projects and team screen - responsive layout for projects screen on desktop - allow user to access original functions on desktop - fix some css issues on desktop
- Added a new renderer instructions file to guide agents through the architecture and startup flow of the app. - Implemented the ProjectsScreen and TeamsScreen components with responsive layouts and mobile-friendly interactions. - Created utility functions for route management and navigation, enhancing the user experience across devices. - Split the old home screen into two pages, where the latter (viewing a team's projects) is now considered "home" - TT-6860 update GPT5 logic - TT-6813 fix card styles (sillsdev#80) - Cleaning up some temp items in an effort to bring Teams and Projects to a unified experience on desktop and mobile - Adding Edit Workflow for desktop - Update memory preferences for response guidelines and automated browser usage - Show Members button and dialog on Projects screen - Updated strings
Refactored confirmation dialog into TeamDialog to remove duplication. And removed unused ref to TeamDialog.
| setExitAlert(true); | ||
| } | ||
| const queueLength = remote?.requestQueue.length ?? 0; | ||
| const queueLength = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain or revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's failing the Husky build such that I couldn't check in. Red-lining the IDE as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see it defined anywhere, though I must admit I didn't look outside the file. Maybe it's something from a newly added package and I need to run npm i?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remote.requestQueue is used in many places. You can't just change logic because it's inconvenient to you. Revert the change and figure out how to get it to compile please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked again this morning. Same behavior
Refactored confirmation dialog into TeamDialog to remove duplication. And removed unused ref to TeamDialog.