-
Notifications
You must be signed in to change notification settings - Fork 55
Initial DSSE verify APIs #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+311
−134
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c3533e9
verifier: hackety hack on DSSE support
woodruffw d7464c7
hackety hack
woodruffw 7cfa154
Merge branch 'main' into ww/dsse-verify
woodruffw 40ec79c
sigstore, test: initial DSSE verify APIs
woodruffw 1c20552
sigstore: lintage
woodruffw 4da4412
test: fix test_sign_prehashed
woodruffw 47dbf17
sigstore: cap off DSSE verification
woodruffw a03520d
sigstore: judicious ignores
woodruffw 3f4cc2a
Merge remote-tracking branch 'origin/main' into ww/dsse-verify
woodruffw b31f46b
Merge branch 'main' into ww/dsse-verify
woodruffw d8663b0
test: add a DSSE roundtrip test
woodruffw c49cb70
missing call
woodruffw 073ce52
fix more types
woodruffw 3daaf49
Merge branch 'main' into ww/dsse-verify
woodruffw 6d7d3af
fix test
woodruffw a00b9db
verifier: typo
woodruffw c44ca12
rekor: remove _dsse_from_parts
woodruffw e1753ff
dsse, verifier: handle multiple sigs gracefully
woodruffw e5aa3b2
Merge branch 'main' into ww/dsse-verify
woodruffw 66cdf8a
Merge branch 'main' into ww/dsse-verify
woodruffw 7a1cb83
Merge branch 'main' into ww/dsse-verify
woodruffw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose at this point it should be just
hashedrekord_from_parts()
without underscore. Sincerekor
is private, it does not seem important tough...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it probably should since it's entirely private APIs. I'll iterate on this with the follow-up PRs for refactoring.