Skip to content

Remove default props for React 19 compat #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tidychips
Copy link

Fixes #709, #763, #774

What did you change (functionally and technically)?
Removes defaultProps for functional components as React 18.3 warns that they're deprecated, and React 19 fully removes support for them.

Checklist (remove this list before you submit the PR)

  • Are there tests for the new code? Existing tests cover these changes
  • Does the code comply to our code conventions? Yes
  • Does the PR resolve the whole issue? Yes

Additional review hints (remove this list before you submit the PR)

  • Besides the code review, what should the reviewer test? Regression test previous functionality
  • Are there any edge cases? None that I know of
  • Do you have any test files or test set-up? No
  • Could your changes cause side effects elsewhere in the code base? Yes

Copy link

changeset-bot bot commented May 1, 2025

🦋 Changeset detected

Latest commit: 517d8e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-mentions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-mentions ❌ Failed (Inspect) May 1, 2025 3:08pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention: Support for defaultProps
2 participants