Skip to content

Add Eng-Prime-Review GHA Workflow - 14018 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

cassieemb
Copy link
Contributor

Other Changes Pull Request

Description

When @eng-prime-reviewers is added as a team reviewer on a prime-rails PR, our github workflow uses the team assignment to individually add each team member as a reviewer, and then removes the team tag.

This is because with a team tag, any approving review is enough to take away the team tag, and only that person remains as the reviewer. Ideally, we'd like every team member to have the opportunity to review pull requests, even if it's after they are merged.

.github/workflows/assign_reviewers_from_team.yml

Related Issue

Link to the issue here: Issue #14018

Type of Change

  • Docusaurus update/maintenance
    • Dependency update
    • Configuration change
    • Plugin update
    • Bug fix
    • Style Change
  • Performance improvement
  • Refactoring
  • Build process update
  • Other (please specify): GHA Workflow Addition

Other Change Details (if applicable)

This adds the described workflow to the docs repo.

Motivation and Context

prime-rails is only one of our repos, and this workflow would be helpful in any repo that we frequently work in. We can safely add this to any repo without causing problems for other teams, as the workflow is only triggered when @eng-prime-review is tagged.

Checklist:

  • My changes follow the style guidelines of this project
  • I have performed a self-review of my changes
  • My changes generate no new warnings
  • Builds successfully locally

Additional Notes

N/A

Copy link

netlify bot commented May 21, 2025

Deploy Preview for signalwire-docs ready!

Name Link
🔨 Latest commit f771ac6
🔍 Latest deploy log https://app.netlify.com/projects/signalwire-docs/deploys/682de12d58017d0008f9c0fc
😎 Deploy Preview https://deploy-preview-287--signalwire-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cassieemb cassieemb requested a review from a team May 21, 2025 14:21
@SignalWire-Bot SignalWire-Bot requested review from diego-signalwire, glanotte, imfaruk, khadijagardezi, kpmcguire, meyerisabela and Mikeysax and removed request for a team May 21, 2025 14:21
@cassieemb
Copy link
Contributor Author

Closing this out, as we would like to avoid using workflows with PATs in public repos.

@cassieemb cassieemb closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/general General Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant