Add Eng-Prime-Review GHA Workflow - 14018 #287
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other Changes Pull Request
Description
When
@eng-prime-reviewers
is added as a team reviewer on a prime-rails PR, our github workflow uses the team assignment to individually add each team member as a reviewer, and then removes the team tag.This is because with a team tag, any approving review is enough to take away the team tag, and only that person remains as the reviewer. Ideally, we'd like every team member to have the opportunity to review pull requests, even if it's after they are merged.
.github/workflows/assign_reviewers_from_team.yml
Related Issue
Link to the issue here: Issue #14018
Type of Change
Other Change Details (if applicable)
This adds the described workflow to the
docs
repo.Motivation and Context
prime-rails is only one of our repos, and this workflow would be helpful in any repo that we frequently work in. We can safely add this to any repo without causing problems for other teams, as the workflow is only triggered when
@eng-prime-review
is tagged.Checklist:
Additional Notes
N/A