Skip to content

fixed: Video preview turns black when you attach another video or image into a yet unsent message - #8016

Open
Eichhorn10 wants to merge 2 commits into
signalapp:mainfrom
Eichhorn10:fix/7222-attachment-preview
Open

Eichhorn10 wants to merge 2 commits into
signalapp:mainfrom
Eichhorn10:fix/7222-attachment-preview

Conversation

@Eichhorn10

@Eichhorn10 Eichhorn10 commented Sep 6, 2026

Copy link
Copy Markdown

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A pnpm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

This fix ensures that draft attachments retain their nested screenshot data and legacy screenshotPath after being restored. Users can therefore continue to see and use draft attachments with their associated screenshots correctly.

Testing

  • Manually tested adding multiple videos, removing them again, and sending them successfully
  • Tested on CachyOS (Arch Linux) with KDE Plasma 6.7.4 and no other devices
  • Added unit tests covering:
    • attachments with nested screenshot metadata
    • attachments with legacy screenshotPath
    • image attachments without screenshots
    • video attachments without screenshots

Fixes #7222

Keep nested screenshot and legacy screenshotPath fields in the resolved attachments. Add tests for nested screenshots, legacy screenshots, images without screenshots, and videos without screenshots.
@Eichhorn10 Eichhorn10 changed the title Fix/7222 attachment preview fixed: Video preview turns black when you attach another video or image into a yet unsent message Sep 6, 2026
@trevor-signal
trevor-signal self-requested a review September 10, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video preview turns black when you attach another video or image into a yet unsent message

1 participant