Make read status on Note to Self only show if read receipts enabled in settings

[lamemakes]

Contributor checklist:

• My contribution is not related to translations.
• My commits are in nice logical chunks with good commit messages
• My changes are rebased on the latest main branch
• A pnpm run ready run passes successfully (more about tests here)
• My changes are ready to be shipped to users

Description

A pretty minute change to make the desktop client consistent with Android client (didn't have the resources to test iOS at time of writing). Currently, even if read receipts are off, a Note to Self message will show a status icon of read once successfully sent. This change makes Notes to Self messages only show as delivered when read receipts are disabled.

Along with mirroring the Android Signal client's functionality, this makes more sense to me personally as it could be confusing to users to have read receipts showing up at all after disabling.

Thanks for taking a look, Cheers!

[lamemakes]

while digging in the code it seemed the easiest way to access the read receipt setting was via the read-receipt-setting storage item, happy to swap that for another wrapper or something if there's a better way!

[scottnonnenberg-signal]

Thanks for looking at this - before I look at the code, I'll be talking to our design folks, to see if this change is what we want.

[lamemakes]

thanks @scottnonnenberg-signal! happy to raise an issue in the android client repo if this is decided against