#7155 If a Group Link contains a query string, that is now ignored #7161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnored. Instagram adds tracking via the Query string which caused Signal to be unable to lookup the group
galiat
force-pushed
the
galia-fix-issue-7155-clean
branch
from
f01b356 to
b6d3b05
Compare
ImAwsumm
approved these changes
Mar 13, 2025
|
@ImAwsumm thanks for reviewing... what are the next steps? |
|
Pretty sure this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instagram adds tracking via the query string which caused Signal to be unable to lookup the group. Organizations looking to leave Instagram are posting a link to their Signal group as a 'Link in Bio' on Instagram and due to the URL tracking instagram adds, Signal was unable to lookup the group. There might be a better place in the code to remove the query string. Def open to feedback.
First time contributor checklist:
Contributor checklist:
mainbranchnpm run readyrun passes successfully (more about tests here) linting (pprettier) is failing but I think not where Ive made a changeDescription
Describe briefly what your pull request changes. Focus on the value provided to users.
Organizations looking to leave Instagram are posting a link to their Signal group as a 'Link in Bio' on Instagram and due to the URL tracking instagram adds, Signal was unable to lookup the group.
Does it address any outstanding issues in this project?
fixes #7155
Please write a summary of your test approach:
Tested on a Mac. You can see Im not in a group, I click on a link in a bio, and then I land in a group.
Screen.Recording.2025-02-08.at.8.22.12.PM.mov