Close story editor's link preview on outside click #6209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to fix the pipeline? From the logs, it looks like an API key is missing. |
|
Hey there @LBBO. I did some testing of these changes after merging into a private branch, and found that it broke an important behavior: in the Text Story editor, when I clicked in the middle of existing story text to start editing there, the focus would be forced to the end of the text block. I don't see this in recent builds, so it does seem to be a regression with your changes. Also, |
|
Closing, since it's been six months since last activity. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)(They fail due to the issue described in Two timestamp tests fail after cloning repository #5832)
Description
Fixes #6207
This PR adds an event handler to clicks outside of the link preview popup in the story editor to close the corresponding popup. During implementation, I noticed that the font editor serves a similar purpose despite being implemented differently. Most importantly, it's opened by clicks into / next to the story itself. I decided to add a similar event handler nonetheless, but it's in a separate commit, so it can be easily removed from this PR if desired.