feat(ingress-nginx): bump to v1.12.0 #141
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump Ingress nginx to v1.12.0 - add new "performance" dashboard - update docs
Update kustomize projects to v5, dropping depreated fields like `commonLabels`, `patchesJson6902`, and `patchesStrategicMerge`. I found a bug (IMO) with kustomize v5: `patches` are applied before `commonLabels` (and `labels`) where `patchesJson6902` were applied after `commonLabels` (and `labels`). Ref: kubernetes-sigs/kustomize#5875 This has the side effect that the configmap and certificate now have an additional label `type: external` (or `type: internal`, respectively).
ralgozino
force-pushed
the
feat-nginx-1.12.0
branch
from
1f183da to
040d61b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 💡
Closes https://github.com/sighupio/product-management/issues/573
Relates:
Description 📝
Notice that updating the kustomize projects to drop deprecated fields (like
commonLabelsandpatchesJson6902) had a side-effect that I could not solve.The side effect is the following changes:
and the same for the internal ingress controller:
THESE CHANGES ARE APPLIED BY
kappWITHOUT RECREATING THE OBJECTS, SO THEY SHOULD NOT HAVE ANY IMPACT.Breaking Changes 💔
Upstream has introduced some breaking changes in v1.12.0, I don't think they have direct impact on how we use it, but it may affect some end-users of KFD.
Breaking changes that I think are relevant to our end-users:
I mentioned these changes in the the unreleased.md file too.
Tests performed 🧪
Future work 🔧